Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamodb: Auto discover AWS Account #2148

Merged
merged 2 commits into from
Nov 20, 2024
Merged

dynamodb: Auto discover AWS Account #2148

merged 2 commits into from
Nov 20, 2024

Conversation

meiao
Copy link
Contributor

@meiao meiao commented Nov 20, 2024

Overview

Allows the DynamoDB instrumentation to auto-discover the AWS account ID, so it does not have to be provided using the Cloud API nor configuration.

Related Github Issue

Closes #2124

Adds call to the new API on DynamoDB instrumentation
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.74%. Comparing base (ff8fa95) to head (05b0c28).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...om/newrelic/agent/cloud/AwsAccountDecoderImpl.java 82.14% 2 Missing and 3 partials ⚠️
...in/java/com/newrelic/agent/cloud/CloudApiImpl.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2148      +/-   ##
============================================
+ Coverage     70.72%   70.74%   +0.01%     
- Complexity     9987    10008      +21     
============================================
  Files           841      842       +1     
  Lines         40290    40346      +56     
  Branches       6107     6115       +8     
============================================
+ Hits          28495    28541      +46     
- Misses         9051     9058       +7     
- Partials       2744     2747       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@meiao meiao merged commit a9ae0b2 into main Nov 20, 2024
111 checks passed
@meiao meiao deleted the dynamodb-decode-aws-account branch November 20, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB: auto discovery of the account ID
3 participants