Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpanEventFactory - adding null check on server port #2127

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

meiao
Copy link
Contributor

@meiao meiao commented Nov 4, 2024

Overview

SpanEventFactory#setServerPort received an int, but the methods that provided this int returned an Integer.
A case was found where the port received was null and caused an NPE.
Adding a null check to prevent it.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.70%. Comparing base (d1111df) to head (6e293c6).

Files with missing lines Patch % Lines
...elic/agent/service/analytics/SpanEventFactory.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2127   +/-   ##
=========================================
  Coverage     70.69%   70.70%           
- Complexity     9983     9986    +3     
=========================================
  Files           841      841           
  Lines         40289    40290    +1     
  Branches       6107     6107           
=========================================
+ Hits          28484    28487    +3     
  Misses         9062     9062           
+ Partials       2743     2741    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meiao meiao merged commit fbfe11b into main Nov 5, 2024
111 checks passed
@meiao meiao deleted the msg-params-null-check branch November 5, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants