Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-lambda: use cloud api #2115

Merged
merged 2 commits into from
Oct 30, 2024
Merged

aws-lambda: use cloud api #2115

merged 2 commits into from
Oct 30, 2024

Conversation

meiao
Copy link
Contributor

@meiao meiao commented Oct 29, 2024

Overview

Uses the Cloud API data to assemble ARN in cases where that data is not available in the SDK.

Changes ARN assembly code to accept more partial ARNs.

Related Github Issue

Fixes #2072 #2073

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.52%. Comparing base (ec234dd) to head (3cea442).

❗ There is a different number of reports uploaded between BASE (ec234dd) and HEAD (3cea442). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ec234dd) HEAD (3cea442)
2 1
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2115       +/-   ##
=============================================
- Coverage     70.66%   35.52%   -35.14%     
+ Complexity     9964     4766     -5198     
=============================================
  Files           840      840               
  Lines         40251    40251               
  Branches       6106     6106               
=============================================
- Hits          28442    14301    -14141     
- Misses         9065    24024    +14959     
+ Partials       2744     1926      -818     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meiao meiao merged commit 62e9dbd into main Oct 30, 2024
111 checks passed
@meiao meiao deleted the lambda-cloud-api branch October 30, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update AWS_LAMBDA_FUNCTION support to include account ID
3 participants