Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpurlconnection metric state use weakref tracers #2082

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

obenkenobi
Copy link
Contributor

Overview

Within the HttpUrlConnection instrumentation module inside the Metric State class, TracedMethod member variables are replaced with weak references. This can help reduce memory usage because the TracedMethod instances can be garbage collected sooner.

Related Github Issue

#2048

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.59%. Comparing base (9b8a401) to head (d60721a).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2082   +/-   ##
=========================================
  Coverage     70.59%   70.59%           
- Complexity     9879     9880    +1     
=========================================
  Files           829      829           
  Lines         39960    39960           
  Branches       6081     6081           
=========================================
  Hits          28208    28208           
  Misses         9021     9021           
  Partials       2731     2731           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@obenkenobi obenkenobi merged commit eb28f6c into main Oct 1, 2024
111 checks passed
@obenkenobi obenkenobi deleted the httpurlconnection-weakref-tracer branch October 1, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants