Cloud API #2081
Merged
Cloud API #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2081 +/- ##
============================================
+ Coverage 70.57% 70.61% +0.03%
- Complexity 9875 9907 +32
============================================
Files 829 833 +4
Lines 39945 40036 +91
Branches 6078 6091 +13
============================================
+ Hits 28191 28270 +79
- Misses 9024 9033 +9
- Partials 2730 2733 +3 ☔ View full report in Codecov by Sentry. |
jbedell-newrelic
approved these changes
Oct 1, 2024
jtduffy
approved these changes
Oct 10, 2024
| if (accountInfo != null) { | ||
| accountInfo.remove(cloudAccountInfo); | ||
| } | ||
| } |
There was a problem hiding this comment.
Should there be a short-circuit return here or is it ok to have a cloudAccountInfo with a null value?
There was a problem hiding this comment.
yes, it should short circuit.
It is also ok to have null values. But short circuiting prevents some overhead.
Update documentation to inform the behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Introduces the Cloud API, which allows cloud account information to be passed to the agent.
This information is required by some instrumentation modules to be able to form cloud resource identifiers which are used to link a monitored application to the cloud resources it uses.
Related Github Issue
Fixes #2003
Checks