Add instrumentation for glassfish-jul-extension logging library #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2049 +/- ##
=========================================
Coverage 70.57% 70.57%
Complexity 9875 9875
=========================================
Files 829 829
Lines 39945 39945
Branches 6078 6078
=========================================
Hits 28191 28191
- Misses 9024 9026 +2
+ Partials 2730 2728 -2 ☔ View full report in Codecov by Sentry. |
jtduffy
approved these changes
Sep 16, 2024
obenkenobi
approved these changes
Sep 16, 2024
obenkenobi
reviewed
Sep 16, 2024
...sh-jul-extension-7/src/main/java/org/glassfish/main/jul/GlassFishLogger_Instrumentation.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2027
GlassFish 7 provides it’s own implementation of the JUL Logger class which causes the JUL instrumentation to fail for log forwarding/log metrics, though it does work for log decorating. This PR adds a new instrumentation module to weave the
GlassFishLoggerto support log forwarding/log metrics.Related integration test PR is here: https://github.com/newrelic/java-agent-integration-tests/pull/284
Here's a test run of this branch running against the new AITs: https://github.com/newrelic/newrelic-java-agent/actions/runs/10857259232/job/30133452461