Add Jedis-5.0.0 Instrumentation Module #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1969 +/- ##
============================================
- Coverage 70.67% 70.61% -0.06%
- Complexity 9861 9873 +12
============================================
Files 826 829 +3
Lines 39792 39914 +122
Branches 6061 6077 +16
============================================
+ Hits 28124 28187 +63
- Misses 8946 8998 +52
- Partials 2722 2729 +7 ☔ View full report in Codecov by Sentry. |
deleonenriqueta
changed the title
jbedell-newrelic
previously approved these changes
Jul 17, 2024
meiao
reviewed
Jul 17, 2024
| } | ||
|
|
||
| verifyInstrumentation { | ||
| passes 'redis.clients:jedis:[5.0.0,6.0.0)' |
There was a problem hiding this comment.
why not use
passesOnly 'redis.clients:jedis:[5.0.0,)
If it works for 6.0.0, then we won't have to change this. If it doesn't, the verify instrumentation will tell us about it.
jasonjkeller
requested changes
Aug 2, 2024
instrumentation/jedis-5.0.0/src/main/java/redis/clients/jedis/Connection_Instrumentation.java
Outdated
Show resolved
Hide resolved
jasonjkeller
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #1475