Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ThreadStateSamplerTest flicker #196

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Fix ThreadStateSamplerTest flicker #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion newrelic-agent/src/test/java/com/newrelic/agent/threads/ThreadStateSamplerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,9 @@ public void testCpuTimeMetrics() {
cpuCalculationTimeSeconds >= totalTimeSeconds);
assertTrue("UserTime: " + userTimeSeconds + ", SystemTime: " + systemTimeSeconds,
userTimeSeconds > systemTimeSeconds);
// This test is prone to flickering due to high load scenarios and rounding errors, hence the modifier added to totalTimeSeconds
assertTrue("TotalTime: " + totalTimeSeconds + ", SystemTime: " + systemTimeSeconds + ", UserTime: " + userTimeSeconds,
totalTimeSeconds + 0.2 >= systemTimeSeconds + userTimeSeconds); // account for rounding error
totalTimeSeconds + 4.0 >= systemTimeSeconds + userTimeSeconds); // account for rounding error

// Since we can't guarantee the exact total time, it should be
// between 1 and 5 (since we had a busywork loop for ~5000ms)
Expand Down