Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1882
This PR introduces a new completable future module
java.completable-future-jdk11
, for JREs 11 and higher.The reason for this change was the need to instrument
CompletableFuture.completeAsync
, which was introduced in Java 9 and was not part of our previous instrumentation. The new module adds support for this method (all other instrumentation is the same asjava.completable-future-jdk8u40
).We decided as a team to have this instrumentation build with Java 11 and apply to Javas 11+. Javas 8-10 will use the existing CF module.
Other things of note:
java.completable-future-jdk8u40
module,Skip_SecurityPolicy
. This is to prevent JREs 11 and higher from loading the module.WeaveUtils
to allow the weaver to recognize Java 9 and 10 runtimes.