Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pekko http #1850

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Pekko http #1850

merged 5 commits into from
Apr 17, 2024

Conversation

kanderson250
Copy link
Contributor

@kanderson250 kanderson250 commented Apr 11, 2024

Resolves #1816

This introduces instrumentation for Apache Pekko HTTP via the pekko-http and pekko-http-core libraries.

This instrumentation supports Scala 2.13, the default Scala version for Pekko.

The instrumentation is nearly a direct lift of the existing akka-http-2.13_10.1.8 and akka-http-core-2.13_10.2.0 libraries. One small instrumentation change has been made in org.apache.pekko.http.scaladsl.server.PekkoExecutionDirectives, where we now instrument createAsyncHandler instead of seal. This was necessary to avoid issues with implicit conversions that sidestepped the previous instrumentation for seal.

AITs have also been added (to be merged later), the test app and the tests

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.87%. Comparing base (dd32a0f) to head (20d23eb).
Report is 42 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1850      +/-   ##
============================================
- Coverage     70.90%   70.87%   -0.03%     
+ Complexity     9977     9973       -4     
============================================
  Files           829      829              
  Lines         39984    39985       +1     
  Branches       6058     6058              
============================================
- Hits          28349    28340       -9     
- Misses         8912     8915       +3     
- Partials       2723     2730       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanderson250 kanderson250 merged commit dff61db into main Apr 17, 2024
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Pekko HTTP
3 participants