1757 log sender sends too much #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulating the new maxSampleStored after a config file change.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1784 +/- ##
============================================
+ Coverage 70.85% 70.86% +0.01%
- Complexity 9944 9948 +4
============================================
Files 826 827 +1
Lines 39868 39873 +5
Branches 6040 6040
============================================
+ Hits 28248 28257 +9
+ Misses 8892 8891 -1
+ Partials 2728 2725 -3 ☔ View full report in Codecov by Sentry. |
jtduffy
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store off the reportPeriodInMillis from the backend, and use it to calculate the proper maxSamplesStored on config file change.