Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implementation title for the zio modules #1781

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

obenkenobi
Copy link
Contributor

The zio instrumentation modules have the wrong implementation titles. This PR simply fixes that so the ZIO 1 and ZIO 2 modules are compiled correctly

@obenkenobi
Copy link
Contributor Author

This is an add on to a previous PR: #1778

@obenkenobi obenkenobi mentioned this pull request Mar 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.99%. Comparing base (085996e) to head (6e1151b).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1781      +/-   ##
============================================
- Coverage     70.85%   69.99%   -0.86%     
+ Complexity     9943     9844      -99     
============================================
  Files           826      826              
  Lines         39868    39868              
  Branches       6040     6040              
============================================
- Hits          28249    27907     -342     
- Misses         8890     9275     +385     
+ Partials       2729     2686      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@obenkenobi obenkenobi merged commit 44d1dd5 into main Mar 4, 2024
104 checks passed
@obenkenobi obenkenobi deleted the zio-2-fix-impl-title branch May 2, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants