Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring 6 Jakarta point cuts #1544

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Spring 6 Jakarta point cuts #1544

merged 4 commits into from
Oct 11, 2023

Conversation

jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Oct 9, 2023

Duplicate of #1505 courtesy of @sokolek
Resolves #1523

  • Implements Spring method pointcuts for the Jakarta namespace
  • Reverts TomcatServletRequestListener change that searched for exception instances using a Spring specific key; exceptions are now handled via the additional pointcuts

@jtduffy jtduffy changed the title Spring 6 Jakarta point cuts DO NOT MERGE; TESTS ONLY Spring 6 Jakarta point cuts Oct 11, 2023
@jtduffy jtduffy requested a review from a team October 11, 2023 17:06
@codecov-commenter
Copy link

Codecov Report

Merging #1544 (f9f6132) into main (c94127d) will increase coverage by 0.01%.
Report is 12 commits behind head on main.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #1544      +/-   ##
============================================
+ Coverage     70.61%   70.62%   +0.01%     
- Complexity     9761     9781      +20     
============================================
  Files           814      816       +2     
  Lines         39313    39419     +106     
  Branches       5970     5978       +8     
============================================
+ Hits          27759    27838      +79     
- Misses         8866     8882      +16     
- Partials       2688     2699      +11     
Files Coverage Δ
.../frameworks/spring/HandlerInterceptorPointCut.java 0.00% <ø> (ø)
...meworks/spring/SpringExceptionHandlerPointCut.java 0.00% <ø> (ø)
...ts/frameworks/spring/SpringDispatcherPointCut.java 0.00% <0.00%> (ø)
...ameworks/spring/HandleInternalInvokerPointCut.java 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jtduffy jtduffy merged commit 5a75a5e into main Oct 11, 2023
102 checks passed
@jtduffy jtduffy deleted the spring6-pointcut branch October 11, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Migrate Spring instrumentations from javax to jakarta to fix transaction names in Spring 6 / Spring Boot 3
4 participants