add s12y metrics for setUserId API call #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ric name reporting in NewRelicApiImplementation.setUserId
meiao
approved these changes
Oct 5, 2023
jtduffy
reviewed
Oct 6, 2023
| @@ -298,6 +298,7 @@ public void addCustomParameters(Map<String, Object> params) { | |||
| */ | |||
| @Override | |||
| public void setUserId(String userId) { | |||
| MetricNames.recordApiSupportabilityMetric(MetricNames.SUPPORTABILITY_API_SET_USER_ID); | |||
There was a problem hiding this comment.
I don't know the specifics of the ticket, but do we want to send the metric if the call is ignored due to high security being enabled? Or have another metric for when it is ignored due to high security?
jtduffy
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1519