Updated the getInputStream method on EmbeddedJars to just use the Jar… #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…File.getInputStream for a entry by name, rather than parsing thru them. This Is fixing a problem where sometimes a JAR file in constructed in such a way that JarInputStream can't seem to process it correctly, possibly due to the order of the entries inside. (Possibly related to this: https://bugs.openjdk.org/browse/JDK-8031748 )
meiao
approved these changes
Jul 28, 2023
newrelic-agent/src/main/java/com/newrelic/agent/service/module/EmbeddedJars.java
Outdated
Show resolved
Hide resolved
jtduffy
approved these changes
Jul 28, 2023
Codecov Report
@@ Coverage Diff @@
## main #1422 +/- ##
============================================
+ Coverage 68.60% 68.63% +0.02%
- Complexity 9493 9495 +2
============================================
Files 816 816
Lines 39365 39358 -7
Branches 5967 5965 -2
============================================
+ Hits 27006 27012 +6
+ Misses 9692 9684 -8
+ Partials 2667 2662 -5
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…File.getInputStream for a entry by name, rather than parsing thru them.
This Is fixing a problem where sometimes a JAR file in constructed in such a way that JarInputStream can't seem to process it correctly, possibly due to the order of the entries inside. (Possibly related to this: https://bugs.openjdk.org/browse/JDK-8031748 )