NR-106006 disable userid when high security #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obenkenobi
commented
May 10, 2023
| @@ -26,7 +26,7 @@ public void service(ServletRequest request, ServletResponse response) { | |||
| if (request instanceof HttpServletRequest) { | |||
| Principal principal = ((HttpServletRequest) request).getUserPrincipal(); | |||
| if (principal != null) { | |||
| AgentBridge.getAgent().getTransaction().getAgentAttributes().put("user", principal.getName()); | |||
| NewRelic.setUserName(principal.getName()); | |||
There was a problem hiding this comment.
This does the same thing but adds additional useful logs and a supportability metric, SetUserName. This also helps me reduce the amount of times I explicitly check if HSM is enabled
There was a problem hiding this comment.
didn't this use a different parameter name?
I confused this with another method.
There was a problem hiding this comment.
Ah ok! To clarify, this method adds the "user" attribute. This is the old way of us doing "user" tracking and was meant for the browser agent to use.
Since user tracking is meant to be disabled in HSM, it makes sense it should apply to this method too.
jtduffy
approved these changes
May 10, 2023
meiao
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled user tracking when high security mode is enabled