NEWRELIC-7259 Add support for HttpClient v5.0+ #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the secondary processResponse method that was a bit redundant. Code cleanup in prep for logging review
jbedell-newrelic
requested review from
meiao,
jasonjkeller,
jtduffy,
tbradellis,
obenkenobi,
deleonenriqueta and
kanderson250
Codecov Report
@@ Coverage Diff @@
## main #1252 +/- ##
=======================================
Coverage ? 57.94%
Complexity ? 8523
=======================================
Files ? 943
Lines ? 42264
Branches ? 6150
=======================================
Hits ? 24489
Misses ? 15364
Partials ? 2411 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jtduffy
approved these changes
May 10, 2023
...lient-5.0/src/main/java/com/nr/agent/instrumentation/httpclient50/WrappedFutureCallback.java
Outdated
Show resolved
Hide resolved
tbradellis
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds instrumentation for HttpClient 5.0+, both the classic and async usages.
Related Github Issue
#800