Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar #1190

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Fix grammar #1190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions instrumentation/spring-webflux-6.0.0/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
Spring Webflux Instrumentation
===============================

This instrumentation assumes that Spring Webflux usage primarily centered
This instrumentation assumes that Spring Webflux usage primarily centered
around maintaining non-blocking flow from the beginning of a request to
the response rendering completion. If blocking calls occur during the request
handling, it is possible that the agent will lose transaction context and
transaction naming will not be able to work as intended.
the response rendering completion. If blocking calls occur during the request
handling, it is possible that the agent will lose transaction context and
transaction naming will not be able to work as intended.

This is especially likely to happen when using a `ParallelScheduler`
and `@RequestBody` with a parameter that is NOT wrapped in a `Mono` or `Flux`.
Expand All @@ -19,9 +19,9 @@ public Mono<String> submit(@RequestBody String body) {
}
```

When the `@RequestBody` is past as a parameter in this manner, the transaction
naming might show up as `NettyDispatcher`. If so, simply wrap the
`RequestBody` parameter in a `Mono` as shown:
When the `@RequestBody` is passed as a parameter in this manner, the
transaction naming might show up as `NettyDispatcher`. If so, simply wrap
the `RequestBody` parameter in a `Mono` as shown:

```java
@PostMapping("/some/path")
Expand Down