-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log Cats Effect 2 instrumentation with Finest log level #1173
Conversation
|
1d37716
to
92287f4
Compare
@mbszarek thanks for the PR! We'll take this up during upcoming PR reviews |
Added commits just to re-trigger GHA as we changed our workflows |
Codecov Report
@@ Coverage Diff @@
## main #1173 +/- ##
=======================================
Coverage ? 57.86%
Complexity ? 8523
=======================================
Files ? 940
Lines ? 42188
Branches ? 6150
=======================================
Hits ? 24412
Misses ? 15365
Partials ? 2411 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Due to GHA issues due to working from forked PRs atm, this PR will then be moved to a new PR off a non-forked branch. |
Before contributing, please read our contributing guidelines and code of conduct.
Overview
In one of previous PRs somebody introduced an info log in CE 2 instrumentation that was being logged on every instrumentation of IO.shift and it wasn't caught by neither
application_logging.enabled
property, norlog_level
. This PR fixes it by making this log on Finest level only if it's applicable.Related Github Issue
Include a link to the related GitHub issue, if applicable
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
Checks
[ ] Are your contributions backwards compatible with relevant frameworks and APIs?
[ ] Does your code contain any breaking changes? Please describe.
[ ] Does your code introduce any new dependencies? Please describe.