Nr 59596 jboss logging #1126
Merged
Nr 59596 jboss logging #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtduffy
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for JBoss Logging.
Also adds a new
instrumentationattribute on log events for all logging frameworks so that we can easily identify which instrumentation module was responsible for reporting a given log event. This makes troubleshooting potential issues much easier.The
logging.pyAIT contains most of the testing for this instrumentation since a JBoss/Wildfly server needs to be started up to test it properly. It's been run successfully locally a bunch of times. https://github.com/newrelic/java-agent-integration-tests/pull/153