NR-2449 Add Log4j1 instrumenation with MDC support #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twcrone
force-pushed
the
tcrone/log4j1-mdc
branch
from
32d1728 to
06c58e4
Compare
twcrone
requested review from
jtduffy,
obenkenobi,
tbradellis and
jasonjkeller
and removed request for
danybmx
twcrone
force-pushed
the
tcrone/log4j1-mdc
branch
from
06c58e4 to
d2eaec3
Compare
instrumentation/apache-log4j-1/src/test/java/org/apache/log4j/Category_InstrumentationTest.java
Show resolved
Hide resolved
twcrone
force-pushed
the
tcrone/log4j1-mdc
branch
from
d2eaec3 to
a0b6494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Log4j1 instrumentation with MDC suppor
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
Checks
[Y] Are your contributions backwards compatible with relevant frameworks and APIs?
[N] Does your code contain any breaking changes? Please describe.
[N] Does your code introduce any new dependencies? Please describe.