Skip to content

Commit

Permalink
Merge pull request #928 from newrelic/spring-jms-jakarta
Browse files Browse the repository at this point in the history
Update spring-jms dependencies and verifier
  • Loading branch information
jasonjkeller authored Jul 12, 2022
2 parents f3bffb2 + 7eb4d2d commit 191d1c6
Showing 1 changed file with 6 additions and 13 deletions.
19 changes: 6 additions & 13 deletions instrumentation/spring-jms-2/build.gradle
Original file line number Diff line number Diff line change
@@ -1,29 +1,22 @@

dependencies {
implementation(project(":agent-bridge"))
implementation("javax.jms:jms-api:1.1-rev-1")
implementation("org.springframework:spring-jms:2.0")
implementation("jakarta.jms:jakarta.jms-api:2.0.3")
implementation("org.springframework:spring-jms:5.3.21")
}

jar {
manifest { attributes 'Implementation-Title': 'com.newrelic.instrumentation.spring-jms-2' }
}

verifyInstrumentation {
// we'll verify against spring-jms 2.0 anyway, but we can't verify against the classpath (yet) because
// classpath verification adds jms-1.1 project to the classpath and the weaver doesn't allow redefining
// existing classes - it only allows weaving them - so these utility classes throw some API violations:
// WeaveViolation{type=ILLEGAL_CLASS_NAME, clazz=com/nr/agent/instrumentation/jms11/JmsMetricUtil}
// WeaveViolation{type=ILLEGAL_CLASS_NAME, clazz=com/nr/agent/instrumentation/jms11/InboundWrapper}
// ...I think this is desired, but we may want to revisit in the future. for now set verifyClasspath=false
verifyClasspath = false
exclude 'org.springframework:spring-jms:3.2.0.BUILD'
// This is a bad artifact on artifactory
excludeRegex 'org.springframework:spring-jms:5.0.0.(RC)[0-9]*$'
passesOnly 'org.springframework:spring-jms:[0,)'
exclude 'org.springframework:spring-jms:3.2.0.BUILD'
// This is a bad artifact on artifactory
excludeRegex 'org.springframework:spring-jms:5.0.0.(RC)[0-9]*$'
}

site {
title 'Spring JMS'
type 'Messaging'
}
}

0 comments on commit 191d1c6

Please sign in to comment.