Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow profiler to respond to log level changes. #2234

Conversation

nrcventura
Copy link
Member

Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.

Description

Updates the managed agent to notify the profiler if the newrelic.config files changes. Updates the profiler so that it includes a method invoked by the managed agent so that it can reload the newrelic config, and update some of the logging settings. These changes allow the profiler log level to change without restarting the application.

This code was testing manually, with and without an updated profiler. Without an updated profiler, the agent logs an error stating that it couldn't notify the profiler about the configuration changing. With an updated profiler, the profiler log level was successfully changed and messaged began logging at the newer level.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feature/disable-inst-by-config@4c332fc). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                        @@
##             feature/disable-inst-by-config    #2234   +/-   ##
=================================================================
  Coverage                                  ?   73.16%           
=================================================================
  Files                                     ?      440           
  Lines                                     ?    27419           
  Branches                                  ?     2999           
=================================================================
  Hits                                      ?    20060           
  Misses                                    ?     6570           
  Partials                                  ?      789           

Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nrcventura nrcventura merged commit 1d17308 into feature/disable-inst-by-config Feb 7, 2024
77 checks passed
@nrcventura nrcventura deleted the feature-work/profiler-reloads-configuration branch February 7, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants