-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize ContextData from LogEventWireModel #1299
Merged
vuqtran88
merged 2 commits into
app-logging-custom-attributes-feature-branch
from
app-logging-custom-attributes-contextdata-serialization
Nov 1, 2022
Merged
Serialize ContextData from LogEventWireModel #1299
vuqtran88
merged 2 commits into
app-logging-custom-attributes-feature-branch
from
app-logging-custom-attributes-contextdata-serialization
Nov 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chynesNR
reviewed
Oct 31, 2022
src/Agent/NewRelic/Agent/Core/JsonConverters/LogEventWireModelCollectionJsonConverter.cs
Show resolved
Hide resolved
chynesNR
approved these changes
Nov 1, 2022
nr-ahemsath
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
vuqtran88
deleted the
app-logging-custom-attributes-contextdata-serialization
branch
November 1, 2022 18:16
nr-ahemsath
added a commit
that referenced
this pull request
Dec 6, 2022
… instrumentation (#1317) * Add app logging custom attributes settings (#1291) * Add logging custom attributes settings. * Deserialize new logging settings. * Add unit tests * Report new configs. * fix failing test. * Update src/Agent/NewRelic/Agent/Core/Config/Configuration.xsd Co-authored-by: Alex Hemsath <[email protected]> * Update src/Agent/NewRelic/Agent/Core/Config/Configuration.xsd Co-authored-by: Alex Hemsath <[email protected]> * Fix another failing test. * Update src/Agent/NewRelic/Agent/Core/Config/Configuration.xsd Co-authored-by: Alex Hemsath <[email protected]> * Update src/Agent/NewRelic/Agent/Core/Config/Configuration.xsd Co-authored-by: Alex Hemsath <[email protected]> Co-authored-by: Alex Hemsath <[email protected]> * Add context data dictionary to LogEventWireModel * Serialize ContextData from LogEventWireModel (#1299) * Serialize ContextData. * Remove redundant tests. * Update RecordLogMessage() API to take getter function for context data (#1297) * Initial implementation that builds * Working unit tests, include filtration tests * PR feedback * Logging custom attributes: attribute include/exclude filtering per the spec (#1300) * Initial implementation that builds * Working unit tests, include filtration tests * PR feedback * Implementation of filtering with wildcards and specificity order * Refactor 1. Cache rule lists 2. Better test case descriptions * Move log context data filtering to separate class * Performance improvements * More PR feedback * Test config updates, cleanup * Use trygetvalue * Add warning log message and unit test for max clusion cache size exceeded * Add custom attribute support for Serilog logging (#1302) Add custom attribute support for Serilog logging * Adds context data to forwarded log events with log4net (#1305) * capture logevent properties. * POV: Log4net custom attributes capture and integration tests. * Refactored and expand log4net ContextData tests * Updates log4net wrapper to capture context properties with tests * Fix problem with the info level test * Fixed bug in LoggingTester and in Log4netWrapper Co-authored-by: Vu Tran <[email protected]> * NLog/MEL instrumentation adds context data to log event data (#1306) * Working for string keys * Handle non-primitive value objects * Add NLog integration tests * Simplify key to string logic in wrapper * Try to ToString() before falling back to the type name * MEL context data (+3 squashed commit) Squashed commit: [2b0eb96c] WIP [8b82a6cf] WIP - crashing [f9666e6d] WIP * exclude SpanId, TraceId, and ParentId by default from context data * Run context data tests in CI * Cleanup (+1 squashed commits) Squashed commits: [ccaa306a] Cleanup (+1 squashed commits) Squashed commits: [d2ab548b] Add MEL tests * Update unit tests for new default exclude configuration * revert change as it breaks our local decoration tests (this failure is actually related to serilog's behavior, but let's not change it now) Co-authored-by: Josh Coleman <[email protected]> * Serilog context data integration tests (#1307) * Working for string keys * Handle non-primitive value objects * Add NLog integration tests * Simplify key to string logic in wrapper * Add Serilog context data integration tests * Add context data support to SerilogWeb case and test it * Add some null checks to fix failures * Update CHANGELOG.md (#1316) Co-authored-by: Vu Tran <[email protected]> Co-authored-by: Chris Hynes <[email protected]> Co-authored-by: Jacob Affinito <[email protected]> Co-authored-by: Josh Coleman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Serialize ContextData from LogEventWireModel.