Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor storer envvar (NR-302384) #316

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

kilokang
Copy link

There a some integrations (apache, cassandra, nginx, ...) that had a custom storer implementation.

This PR honors back that legacy behavior ins case there is any customer using that feature.

@kilokang kilokang requested review from a team September 20, 2024 09:50
@kilokang kilokang force-pushed the kang-makes/honor-storer-envvar/NR-302384 branch from a0a0404 to 3957db1 Compare September 20, 2024 10:00
gsanchezgavier
gsanchezgavier previously approved these changes Sep 23, 2024
Copy link
Contributor

@gsanchezgavier gsanchezgavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just left a nit, also if its possible to add some test would be nice

persist/storer.go Show resolved Hide resolved
@kilokang kilokang changed the title Honor storer envva (NR-302384) Honor storer envvar (NR-302384) Sep 23, 2024
Base automatically changed from kang-makes/make-timeout-configurable to v3 October 1, 2024 11:40
@kilokang kilokang dismissed gsanchezgavier’s stale review October 1, 2024 11:40

The base branch was changed.

@kilokang kilokang force-pushed the kang-makes/honor-storer-envvar/NR-302384 branch from 3957db1 to 57d0c5d Compare October 1, 2024 11:42
Copy link
Contributor

@gsanchezgavier gsanchezgavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kilokang kilokang merged commit d7269dc into v3 Oct 1, 2024
5 checks passed
@kilokang kilokang deleted the kang-makes/honor-storer-envvar/NR-302384 branch October 1, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants