Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bandit attributes #480

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix: bandit attributes #480

merged 1 commit into from
Jan 14, 2025

Conversation

binaryseed
Copy link
Collaborator

@binaryseed binaryseed commented Jan 13, 2025

  • bandit attribute resp_duration_ms was calculated incorrectly
  • bandit duration can't be calculated from monotonic_time because that is the timestamp of the exception event, so use 0 duration when we can't know the actual duration

@binaryseed binaryseed requested a review from tpitale January 13, 2025 19:23
@binaryseed binaryseed force-pushed the vince/fix-bandit-resp_duration branch from f88a930 to bad8dc8 Compare January 13, 2025 22:50
@binaryseed binaryseed mentioned this pull request Jan 13, 2025
19 tasks
@tpitale tpitale merged commit aa725f2 into master Jan 14, 2025
11 checks passed
@tpitale tpitale deleted the vince/fix-bandit-resp_duration branch January 14, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants