Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional compilation to address warnings #456

Merged
merged 7 commits into from
Jan 7, 2025
Merged

Conditional compilation to address warnings #456

merged 7 commits into from
Jan 7, 2025

Conversation

binaryseed
Copy link
Collaborator

@binaryseed binaryseed commented Dec 16, 2024 •
edited
Loading

Address some warnings that arise across different Elixir versions

  • +0.0
  • Logger.warn

Also modify ConditionalCompile to not need a macro

@binaryseed binaryseed requested a review from tpitale December 16, 2024 03:58
tpitale
tpitale reviewed Dec 16, 2024
View reviewed changes
lib/new_relic/logger.ex Outdated Show resolved Hide resolved
@binaryseed
Copy link
Collaborator Author

This one is ready for review

@binaryseed binaryseed mentioned this pull request Dec 17, 2024
Merged
19 tasks
@tpitale tpitale merged commit 810136a into master Jan 7, 2025
12 checks passed
@tpitale tpitale deleted the vince/conditional-warnings branch January 7, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpitale tpitale tpitale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@binaryseed @tpitale