Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nov 15 - What's New for Pixie Additional Data #10288

Merged
merged 6 commits into from
Nov 15, 2022

Conversation

lazyplatypus
Copy link
Contributor

  • What problems does this PR solve?
    We are launching entities for various types of data that pixie detects. Created a what's new post for this.

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

Hi @lazyplatypus 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

nserrino
nserrino previously approved these changes Nov 11, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Nov 12, 2022

✅ docs-website-develop deploy preview ready

@homelessbirds homelessbirds added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) what's new labels Nov 12, 2022
@x8a
Copy link
Contributor

x8a commented Nov 14, 2022

Hey, @lazyplatypus! Could you please sign the CLA? We need all contributors to do before we can merge their PRs! Thanks!

@x8a x8a changed the title Add What's New for Pixie Additional Data 11/14 - Add What's New for Pixie Additional Data Nov 14, 2022
aalfano7
aalfano7 previously approved these changes Nov 14, 2022
Copy link
Contributor

@aalfano7 aalfano7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestions:

  • Update title to "First-class support now available for Pixie data"
  • (Hyphenate first class in title: "New Relic adds first-class support for Pixie data")
  • Hyphenate long-term in summary: "Automatically detect and export sampled and aggregated data from Pixie for long-term retention"
  • Hyphenate long-term and add comma after technologies: "New Relic automatically detects and exports sampled and aggregated data from Pixie for long-term retention from various technologies, including Kafka..."
  • Change placement of "already" in these sentences: "If you are using Pixie with New Relic with either the Kubernetes integration v2.0.0+ or the Pixie-New Relic Plugin v1.4.2+, no need to do anything else! You should already see entities from your environment directly in your New Relic environment."
  • Link "guided installation path" to: https://docs.newrelic.com/docs/kubernetes-pixie/kubernetes-integration/installation/kubernetes-integration-install-configure

zuluecho9
zuluecho9 previously approved these changes Nov 14, 2022
@zuluecho9 zuluecho9 changed the title 11/14 - Add What's New for Pixie Additional Data Nov 15 - What's New for Pixie Additional Data Nov 14, 2022
Copy link
Contributor

@akristen akristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Merging!

@akristen akristen merged commit a531181 into newrelic:develop Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants