-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NR-308791: Apache Pekko Instrumentation support #329
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IshikaDawda
changed the title
NR-308791: Apache Pekko Http Client Request Interception
NR-308791: Apache Pekko Http Client Instrumentation support
Sep 10, 2024
IshikaDawda
changed the title
NR-308791: Apache Pekko Http Client Instrumentation support
NR-308791: Apache Pekko Instrumentation support
Sep 13, 2024
NR-310454: Unit tests for Apache Pekko
# Conflicts: # settings.gradle
lovesh-ap
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrumentation support for
Please Note : In Apache Pekko Server, we are unable to extract request and response body.
As request body is wrapped in a Source which is similar to Java’s Stream. To read the body, we need to consume this source however, if we do so, the Source will no longer be available to the application.