Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture the PIN code before returning the intent values #36

Merged
merged 6 commits into from
Jan 21, 2021
Merged

Capture the PIN code before returning the intent values #36

merged 6 commits into from
Jan 21, 2021

Conversation

rjmangubat23
Copy link
Contributor

Issue

#33 Capture the PIN code before returning the intent values

Changes

  • Add Capture PIN code implementation
  • Add IDPassManager util class implementation
  • Add ID PASS verification dialog
  • Update latest idpass-lite-java-android-0.1.aar and loading models implementation

Notes

Minimum sdk is changed to version 26 temporarily as ID PASS Lite aar is using Base64 class which @typelogic is still finding a workaround for this via AndroidKeyStore.

@rjmangubat23 rjmangubat23 requested a review from jeremi January 21, 2021 05:36
@rjmangubat23 rjmangubat23 self-assigned this Jan 21, 2021
@rjmangubat23 rjmangubat23 linked an issue Jan 21, 2021 that may be closed by this pull request
Capture the PIN code before returning the intent values #33
Closed
@rjmangubat23 rjmangubat23 mentioned this pull request Jan 21, 2021
Closed
@rjmangubat23 rjmangubat23 merged commit bb68288 into develop Jan 21, 2021
@rjmangubat23 rjmangubat23 deleted the feature/capture-pin branch January 22, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremi jeremi jeremi approved these changes

Assignees

@rjmangubat23 rjmangubat23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capture the PIN code before returning the intent values
2 participants
@rjmangubat23 @jeremi