Upgrade peer dependencies to Capacitor V3, Update documentation #15
Conversation
Update dependencies with dependabot alerts
add option showGuide
|
Tested this PR in android using Ionic/Capacitor. Current release ( Will add interfaces soon. So that it will be easier for developers to follow formats when using |
|
Thank you for the PR ❤️, it may take sometimes to review and merge this. |
|
I think we can merge this to a feature branch for v3 |
|
Thanks @megaxayda! Do you guys have any communication channel (Discord, Skype, or any)? |
|
Updated PR. Added Interface and Updated documentation |
sorry, it is private, we can still discuss on this PR. |
|
Hello @rs2-davebanguilan , can you check if this is different from what you did here? https://github.com/newlogic/smartscanner-capacitor/tree/feature/capacitor-v3 maybe base your pull request directly to that branch? We have decided that each version will have its own branch |
|
Hi @nicholemnl , I'll update my PR and change the base branch to |
rs2-davebanguilan
changed the base branch from
master
to
feature/capacitor-v3
|
Hi @nicholemnl , done updating my PR. If you guys approved my changes for the interface. I can also update the other branches you guys have. |
|
Hello @megaxayda , can you add a discussion tab on this repo? I think my questions will also be asked by other developers that will use this plugin. Thanks! |
|
hi @rs2-davebanguilan , sorry I can't open a discussion tab now, I think you can open new issue for the questions. About the PR, It's LGTM but can you remove package-lock.json, you can update .gitignore to ignore this file. Thanks. |
Issue
#13 Capacitor V3 Support
Changes
ScannerInputConfig,Config,ScannerOptions,BarcodeOptions,NfcOptions,CaptureOptions]