Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Njwe 2585 user sign up form #3195

Merged
merged 9 commits into from
Jan 28, 2025
Merged

Njwe 2585 user sign up form #3195

merged 9 commits into from
Jan 28, 2025

Conversation

scwambach
Copy link
Collaborator

@scwambach scwambach commented Jan 23, 2025 •
edited by mflymfly
Loading

Resolves NJWE-2585

What I did:

  • created a button in the navigation that toggles a modal with the user signup form
  • currently this only mocks an API post
  • it will randomly have a submission error to illustrate the visual
  • there is validation on all inputs
  • Dev review
  • Design review

@scwambach scwambach marked this pull request as ready for review January 24, 2025 18:57
densub
densub approved these changes Jan 28, 2025
View reviewed changes
Copy link

@densub densub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

denish-fearless
denish-fearless approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@denish-fearless denish-fearless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@denish-fearless denish-fearless merged commit 54c85d3 into main Jan 28, 2025
5 checks passed
@denish-fearless denish-fearless deleted the NJWE-2585-user-sign-up-form branch January 28, 2025 17:10
@mflymfly
Copy link
Collaborator

@scwambach Working on finalizing the success message and will send that over asap. The placeholder for now should suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denish-fearless denish-fearless denish-fearless approved these changes

@densub densub densub approved these changes

@ChelseaKR ChelseaKR Awaiting requested review from ChelseaKR

@mflymfly mflymfly Awaiting requested review from mflymfly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scwambach @mflymfly @densub @denish-fearless