exclude tests based on specific dependency - woo, jetpack, wonder #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HostGator Plugin
|
||||||||||||||||||||||||||||
| Project |
HostGator Plugin
|
| Branch Review |
update/cypress-config-for-exclusions
|
| Run status |
|
| Run duration | 26m 53s |
| Commit |
|
| Committer | Evan Mullins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
28
|
Skipped
|
0
|
Passing
|
323
|
| View all changes introduced in this branch ↗︎ | |
HostGator Plugin
|
||||||||||||||||||||||||||||
| Project |
HostGator Plugin
|
| Branch Review |
update/cypress-config-for-exclusions
|
| Run status |
|
| Run duration | 26m 44s |
| Commit |
|
| Committer | Evan Mullins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
1
|
|
Pending
|
28
|
|
Skipped
|
0
|
|
Passing
|
323
|
| View all changes introduced in this branch ↗︎ | |
wpalani
approved these changes
Dec 5, 2024
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This updates the cypress config to exclude tests on their specific dependency. Before these were excluded in one group but had different dependencies. We'll need to routinely check the requirements for each dependency and update as needed.
The Cypress tests have dependencies on the WooCommerce and Jetpack plugins as well as the Wonder Theme. These dependencies each have different requirements, and when they are not met, the test needs to be excluded because the dependency installation will fail. These are relatively few, but it is important to get them set properly so the matrix of tests can reliably pass.
This adds a little helper method for cleanliness that checks requirements/support for each specific dependency and excludes it if they are not met. It includes links to the files that determine requirements in each dependency too, so this can be easily checked in the future as dependencies are updated.
Ideally, we have graceful fallbacks in the modules to address when the dependency is not installed or available. In those cases, the tests are different and not relevant so they still need to be excluded here. Ensuring graceful fallback is beyond the scope of this PR.
Type of Change
Production
Development
Video
Checklist
Further comments