Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc comments to region url data for clarity #780

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

Adds short comments to the file to more clearly document where each link is used.

Also update some links to the latest provided links.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Nov 1, 2024
Copy link

trag-bot bot commented Nov 1, 2024

@trag-bot didn't find any issues in the code! ✅✨

Copy link

cypress bot commented Nov 1, 2024

HostGator Plugin    Run #5158

Run Properties:  status check passed Passed #5158  •  git commit dbceb7b6a5 ℹ️: Merge bd57a36894c039c49fce5f30a20f6f1a3edad6cb into cfa2785726748392cc9d03546f7b...
Project HostGator Plugin
Branch Review update/regional-links
Run status status check passed Passed #5158
Run duration 25m 43s
Commit git commit dbceb7b6a5 ℹ️: Merge bd57a36894c039c49fce5f30a20f6f1a3edad6cb into cfa2785726748392cc9d03546f7b...
Committer Evan Mullins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 31
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

Copy link

cypress bot commented Nov 1, 2024

HostGator Plugin    Run #5139

Run Properties:  status check passed Passed #5139  •  git commit bd57a36894: add comments to region url data for clarity and update to provided doc
Project HostGator Plugin
Branch Review update/regional-links
Run status status check passed Passed #5139
Run duration 28m 01s
Commit git commit bd57a36894: add comments to region url data for clarity and update to provided doc
Committer Evan Mullins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 31
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

@circlecube circlecube changed the base branch from main to develop November 6, 2024 14:31
@circlecube circlecube merged commit 814e61f into develop Nov 6, 2024
26 checks passed
@circlecube circlecube deleted the update/regional-links branch November 6, 2024 14:32
@circlecube circlecube added this to the November 13, 2024 Release milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants