Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/cypress jetpack test as standalone file #46

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

This moves the jetpack test to its own file so it alone can be skipped in envs where jetpack is not supported. This is better than skipping the full test.

I also added a couple of minor dependency updates here.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

this test needs to be skipped at the plugin level when jetpack is not supported due to wp or php versions (in matrix)
@circlecube circlecube self-assigned this Dec 5, 2024
@circlecube circlecube merged commit 177657e into main Dec 11, 2024
2 checks passed
@circlecube circlecube deleted the update/cypress-jetpack-test-as-standalone-file branch December 11, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants