Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/use cli option update #39

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Conversation

circlecube
Copy link
Member

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Nov 8, 2024
@circlecube
Copy link
Member Author

After some discussion this changes the checks for displaying the my plugins and tools page in the plugin submenu and the plugins tabs to only check the hasSolution capability.

This also simplifies the logic in the tests and we can simply use an intercept for all tests which is much faster than using multiple cli commands. I also add a setCapabilities method to the support file, this should be copied and used in other modules as it makes the test much easier to follow.

@circlecube circlecube requested a review from wpscholar November 8, 2024 18:06
@circlecube circlecube merged commit 386ec40 into main Nov 8, 2024
3 checks passed
@circlecube circlecube deleted the update/use-cli-option-update branch November 8, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants