Wp-solutions-PS0-2289 - Checking plugin installation and active state #37
Conversation
* main: troubleshooting test log and performance clean up wp cli commands with wpcli wrapper method add log to test exec commands move the intercept statement to beginning NPM(deps): Bump @wordpress/api-fetch from 7.10.0 to 7.11.0
|
@krsomayagi thanks for submitting. I saw this test wasn't passing in the runner. I merged |
…wp-module-solutions into wp-soln-Press02289
* main: add module supports for login and cli command adjust tests for test isolation pass methods into card component to load plugins endpoint properly and set up better error handling reorder cli commands, add expiration var
Sure. Thank you. |
…wp-module-solutions into wp-soln-Press02289
* main: NPM(deps): Bump @wordpress/api-fetch from 7.11.0 to 7.12.0 NPM Dev(deps-dev): Bump tailwindcss from 3.4.14 to 3.4.15 cleanup plugins page test with intercept and helper to setCapability only check capabilities to determine if plugin page/tab should display wait for intercept before checking page for content use option update instead of set and reload page to ensure fresh data
…nstall plugin commands do not cause failures when plugin is not present
checks attributes are correct in each situation and installer functions pls plugin, free plugin, free install install, installed and active, installed and not active
|
@krsomayagi—This was outdated, so I updated it from |
@circlecube |
| if ( pluginData?.plsProviderName && pluginData?.plsSlug ) { | ||
| return `<button | ||
| title="${ isInstalled ? 'Activate' : 'Install' } Premium Plugin" | ||
| class="nfd-solutions-availble-list-item-button nfd-solutions-${ this.renderNameAsClass( |
There was a problem hiding this comment.
I added this little method renderNameAsClass to give us unique class names for each plugin (which helps select them in tests). I also update the order of these installer attributes so they are consistent in each block. The rest of the file changes are due to lint whitespace edits.
| href="${this.renderCTAUrl(pluginData?.cta?.url)}" | ||
| class="nfd-solutions-availble-list-item-button" | ||
| >${pluginData?.cta?.text}</a>`; | ||
| } else if ( isInstalled ){ // already installed |
There was a problem hiding this comment.
I removed this isActive but not isInstalled section, and instead use the later conditionals to just check if it is a premium/pls or free plugin. Since those are the more pertinent deciders of what the markup should be. I did file a ticket with the installer module though, since if a plugin is installed and not active, the installer opens up and fails to install since the directory already exists. This change doesn't change the issue, but simplifies the logic in rendering these buttons.
* main: update solutions app test NPM(deps): Bump @heroicons/react from 2.1.5 to 2.2.0
|
Heres a video of the plugins Plugins and Tools page before this update: and one with the update: I updated the button when the plugin is already installed to still include the installer attributes for free or pls pluigns, the installer still needs to be updated so it doesn't fail when a plugin is already installed but inactive, ideally it can detect that it is already installed and just activate and redirect. That is in a different module though and beyond scope of this PR. Here we're at least getting a more clear error message that the directory already exists - before it errored and said the API returned a non-success code. |
Proposed changes
Code is added to verify if the plugins are installed and active
Type of Change
Video
Checklist
Further comments