Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Let's eliminate the "Install" and "Activate" button states and always show the CTA label on all the buttons. The URL on the buttons should be the CTA URL from the entitlements API.
Currently, we have a
{siteUrl}
placeholder in the CTA URLs returned from the Hiive entitlements API. This must be replaced with theNewfoldRuntime.siteUrl
value to ensure the link points to the correct place.Data attributes should be dynamically set on all the buttons as follows:
If the "type" attribute in the entitlements API is not "plugin", do not add any data attributes.
Don't set any data attributes if a plugin is installed and active. Doing so will let the button link to the destination in the href attribute.
If the plugin has a download URL in the entitlements API, then set the value of the data-nfd-installer-download-url attribute to that URL.
If the plugin has a PLS slug and provider name, set the data-nfd-installer-plugin-slug and data-nfd-installer-provider-name attributes accordingly.
Ensure no buttons have a
target="_blank"
attribute.Please apply these updates to both "My Plugins & Tools" pages in the Bluehost plugin page (/wp-admin/admin.php?page=bluehost#/my_plugins_and_tools)
Type of Change
Video
Checklist
Further comments