Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test files #21

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Add test files #21

merged 8 commits into from
Oct 29, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

We need to add cypress test integration files so we can ensure these solutions components load as expected.

I've started the files and left comments as to which basic tests are needed, feel free to add more but try not to tie the tests too closely to the HTML structure or content.

We should have basic tests in place for release at least.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

* main: (35 commits)
  update debug json data to latest api response
  capital P dangit
  linting
  pls-provide replaced with plugin-provider
  added linting fixes
  changes
  checking hasSOlution capability
  added data attributes
  kill stray whitespace
  enqueue the installer module scripts
  remove unused and missing nonce reference
  rename localized global var to nfdPluginDetails and update script
  use find on array of active plugin slugs
  lint fix
  update plugin branch name in workflow
  Padding near buttons
  fixes
  fixes
  NPM(deps): Bump @wordpress/api-fetch from 7.9.0 to 7.10.0
  Composer Dev(deps-dev): Bump wp-cli/i18n-command from 2.6.2 to 2.6.3
  ...
* main:
  remove reference to debug data
wpscholar
wpscholar previously approved these changes Oct 23, 2024
@circlecube circlecube requested a review from wpscholar October 29, 2024 18:17
wpscholar
wpscholar previously approved these changes Oct 29, 2024
@circlecube circlecube merged commit 726efe4 into main Oct 29, 2024
3 checks passed
@circlecube circlecube deleted the add/tests branch October 29, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants