Bugfix: Empty Favorites navigation triggers missed icon mapping, breaks modal

[0aveRyan]

Proposed changes

In #127 changing of Icons, I didn't address the NoResults view for favorites which is referencing icon maps that no longer exist.

Currently clicking the Favorites navigation item with Favorites stored works just fine. Clicking Favorites with no favorites triggers the <NoResults /> component and the missing icons cause the modal to crash.

1. This corrects the icon mappings for the two categories there.
2. This removes the CSS class previously needed for WordPress icons that isn't required for Lucide to inherit the proper colors.

Production

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update
• Refactoring / housekeeping (changes to files not directly related to functionality)

Development

• Tests
• Dependency update
• Environment update / refactoring
• Documentation Update

Video

favorites-bug.mp4

Checklist

• I have read the CONTRIBUTING doc
• I have viewed my change in a web-browser
• Linting and tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments