Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS2 305 | Build Fonts Design Step #97

Merged
merged 22 commits into from
Nov 15, 2022

Conversation

officiallygod
Copy link
Member

No description provided.

Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's run php and javascript formatters

includes/Data/Fonts.php Outdated Show resolved Hide resolved
includes/Data/Fonts.php Outdated Show resolved Hide resolved
includes/RestApi/Themes/ThemeFontsController.php Outdated Show resolved Hide resolved
Comment on lines 91 to 98
storedPreviewSettings.settings.styles = [
...result,
{
id: 'customFontProperty',
css: `body {font-family: ${fontPalettesCopy[fontStyle]?.styles?.typography?.fontFamily} !important; }
h6 { font-family: ${fontPalettesCopy[fontStyle]?.styles?.blocks['core/heading']?.typography?.fontFamily} !important; }`,
},
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this hardcoding as part of the 6.1 fix story

@arunshenoy99 arunshenoy99 merged commit 2f46f1e into release/v1.0.0 Nov 15, 2022
@arunshenoy99 arunshenoy99 deleted the PRESS2-305-Build-Fonts-Design-Step branch November 15, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants