-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRESS2 305 | Build Fonts Design Step #97
Merged
arunshenoy99
merged 22 commits into
release/v1.0.0
from
PRESS2-305-Build-Fonts-Design-Step
Nov 15, 2022
Merged
PRESS2 305 | Build Fonts Design Step #97
arunshenoy99
merged 22 commits into
release/v1.0.0
from
PRESS2-305-Build-Fonts-Design-Step
Nov 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunshenoy99
reviewed
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's run php and javascript formatters
src/OnboardingSPA/components/Drawer/DrawerPanel/DesignTypography.js
Outdated
Show resolved
Hide resolved
arunshenoy99
approved these changes
Nov 14, 2022
Comment on lines
91
to
98
storedPreviewSettings.settings.styles = [ | ||
...result, | ||
{ | ||
id: 'customFontProperty', | ||
css: `body {font-family: ${fontPalettesCopy[fontStyle]?.styles?.typography?.fontFamily} !important; } | ||
h6 { font-family: ${fontPalettesCopy[fontStyle]?.styles?.blocks['core/heading']?.typography?.fontFamily} !important; }`, | ||
}, | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove this hardcoding as part of the 6.1 fix story
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.