Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRES2-290 | Learn more Sidebar Skeleton Loading state #89

Conversation

officiallygod
Copy link
Member

No description provided.

@officiallygod
Copy link
Member Author

Video Demo
screen-capture.webm

Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how the get started sidebar looks on release/v1.0.0

Screenshot 2022-10-03 at 6 34 58 PM

This is how it looks on this branch

Screenshot 2022-10-03 at 6 35 50 PM

The borders seem a bit different and there is a new thicker border on the top, might have something to do with margins.

@officiallygod
Copy link
Member Author

This is how the get started sidebar looks on release/v1.0.0

Screenshot 2022-10-03 at 6 34 58 PM

This is how it looks on this branch

Screenshot 2022-10-03 at 6 35 50 PM

The borders seem a bit different and there is a new thicker border on the top, might have something to do with margins.

Sure, Lemme fix styling issues.

@officiallygod
Copy link
Member Author

Screenshot 2022-10-04 at 10 59 12 AM

Screenshot 2022-10-04 at 10 59 30 AM

Current Look!

@arunshenoy99 arunshenoy99 merged commit 81d86ea into release/v1.0.0 Oct 7, 2022
@arunshenoy99 arunshenoy99 deleted the PRESS-2-290-Learn-More-Sidebar-Skeleton-Loading-State branch October 7, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants