Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default state drop down value removed #84

Merged
merged 2 commits into from
Oct 6, 2022
Merged

default state drop down value removed #84

merged 2 commits into from
Oct 6, 2022

Conversation

prasanthreddy22
Copy link

No description provided.

arunshenoy99
arunshenoy99 reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen-capture.webm
@aulisius @prasanthreddy22 Hey guys I was testing this branch out and it seems like the previously selected State is not showing when I come back to the address step. In the recording I selected Florida/Alaska and went to the next step, but when I come back to the address step the state resets to blank again. Is this the behaviour we want?

@prasanthreddy22
Copy link
Author

screen-capture.webm @aulisius @prasanthreddy22 Hey guys I was testing this branch out and it seems like the previously selected State is not showing when I come back to the address step. In the recording I selected Florida/Alaska and went to the next step, but when I come back to the address step the state resets to blank again. Is this the behaviour we want?

@prasanthreddy22
Copy link
Author

prasanthreddy22 commented Oct 3, 2022 •
edited
Loading

@arunshenoy99 the previously selected state should now work as expected.

@arunshenoy99 arunshenoy99 merged commit 616dde0 into trunk Oct 6, 2022
@arunshenoy99 arunshenoy99 deleted the bugfix/state-dropdown-press-4-90 branch October 6, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

@aulisius aulisius aulisius approved these changes

@abhijitb abhijitb abhijitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prasanthreddy22 @abhijitb @aulisius @arunshenoy99