-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRESS 2-230 Live Preview Component Skeleton State #82
Merged
arunshenoy99
merged 20 commits into
release/v1.0.0
from
PRESS-2-230-Live-Preview-Component-Skeleton-State
Oct 6, 2022
Merged
PRESS 2-230 Live Preview Component Skeleton State #82
arunshenoy99
merged 20 commits into
release/v1.0.0
from
PRESS-2-230-Live-Preview-Component-Skeleton-State
Oct 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttps://github.com/newfold-labs/wp-module-onboarding into PRESS-2-230-Live-Preview-Component-Skeleton-State
Video for Demo |
arunshenoy99
requested changes
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's run formatters on all the files as well.
src/OnboardingSPA/components/LivePreview/BlockPreview/stylesheet.scss
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/components/LivePreview/SelectableCard/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/components/LivePreview/SelectableCard/stylesheet.scss
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/pages/Steps/DesignThemeStyles/Preview/index.js
Outdated
Show resolved
Hide resolved
1. Disabled Selecting the Preview while rendering 2. Option to disable Skeleton
Done ✅ |
arunshenoy99
approved these changes
Oct 6, 2022
abhijitb
approved these changes
Oct 6, 2022
Yashita101
approved these changes
Oct 6, 2022
arunshenoy99
deleted the
PRESS-2-230-Live-Preview-Component-Skeleton-State
branch
October 6, 2022 16:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a default Skeleton Loader with a default time of 2500