Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS4-39 Fix responsiveness for ecommerce steps #73

Merged
merged 4 commits into from
Sep 12, 2022

Conversation

aulisius
Copy link
Contributor

@aulisius aulisius commented Sep 6, 2022

No description provided.

@arunshenoy99
Copy link
Member

Screenshot 2022-09-07 at 11 40 03 AM
Screenshot 2022-09-07 at 11 42 52 AM
Screenshot 2022-09-07 at 11 43 31 AM
Screenshot 2022-09-07 at 11 43 44 AM
Screenshot 2022-09-07 at 11 44 05 AM
Screenshot 2022-09-07 at 11 44 48 AM
Screenshot 2022-09-07 at 11 44 57 AM
Screenshot 2022-09-07 at 11 46 02 AM
Looks way better than before, a few things I noticed

  1. There are some warnings popping up when I build the assets. npm run build was the command I used.
  2. We probably need to prevent content overflowing outside the card(on smaller screens and on opening console), not sure if the fix @abhijitb made will take care of it for these steps as well, please reach out to @abhijitb
  3. Step address seems to handle responsiveness better than the other 2 steps maybe we can use similar css? Attaching screenshots of how it looks on our breakpoint devices(some in portrait and some in landscape mode).

@arunshenoy99
Copy link
Member

The frontend checklist we came up with is something like this

  1. Lower End: iPhone 4, portrait and landscape(Closest to 320px)
  2. Higher End: 4k Monitor(3840px * 2160px)
  3. Start from lower end to higher end using device type as responsive.

@officiallygod
Copy link
Member

Hey @aulisius, I found a few very small issues

Screenshot 2022-09-08 at 9 56 44 AM

Here the Text Boxes and Dropdown boxes are not aligned and it looks weird at first, maybe they can sorta fill the whole space? and be more uniform.

Screenshot 2022-09-08 at 9 57 00 AM

Here the Postal Code Input Box was overflowing for some reason for me.

Screenshot 2022-09-08 at 9 57 46 AM

The Minimum device we are targeting for our Module according to David is an iPhone 4 and I saw that the options on this page were quite not readable for a user out clear. So the thing is the text overflows if the option is not selected but if it is then it is cut off.

Screenshot 2022-09-08 at 9 59 49 AM

Lastly again for an iPhone 4 the options were overflowing and were looking weird whereas they were aligned properly for the rest of the phones stacked vertically.

Thanks Please look into this.

@arunshenoy99 arunshenoy99 changed the base branch from trunk to enhance/ecom-mvp-frontend-polish September 9, 2022 08:15
@abhijitb abhijitb merged commit 17512ae into enhance/ecom-mvp-frontend-polish Sep 12, 2022
@aulisius aulisius deleted the fix/ecommerce-responsive branch September 13, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants