PRESS2-60 check for valid twitter handle #71
Conversation
modified: includes/RestApi/SettingsController.php
…or it modified: includes/RestApi/SettingsController.php
…er handle modified: includes/RestApi/SettingsController.php modified: src/OnboardingSPA/components/SocialMediaForm/index.js
modified: src/OnboardingSPA/components/SocialMediaForm/index.js
There was a problem hiding this comment.
Hey, I was testing the Twitter Handle and it was behaving weird for me,
screen-capture.webm
So as you can see for facebook the error goes when I type in the missing ":" but not for twitter and the twitter URL "https://te.com/alllen" also works and sometimes "tw" also works, and maybe we can have some way by which user knows he can enter handle as well?
screen-capture (1).webm
I am not sure if you added the change wherein the valid URLs do get saved and only throws error for invalid ones, but that is not working for me.
modified: includes/RestApi/SettingsController.php
modified: src/OnboardingSPA/components/SocialMediaForm/index.js
There was a problem hiding this comment.
@abhijitb I just tested again after getting Yoast SEO to work, Yoast does not accept @ and the error message says URL or username compared to Facebook, please check the SS
modified: src/OnboardingSPA/components/SocialMediaForm/index.js modified: src/OnboardingSPA/components/Tooltip/stylesheet.scss
modified: includes/RestApi/SettingsController.php
modified: src/OnboardingSPA/components/SocialMediaForm/index.js
modified: includes/RestApi/SettingsController.php