Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Default Values for site types #62

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Removed Default Values for site types #62

merged 3 commits into from
Aug 25, 2022

Conversation

officiallygod
Copy link
Member

Removed Default Values for Primary and Secondary Types

@officiallygod officiallygod added the bug Something isn't working label Aug 22, 2022
@arunshenoy99
Copy link
Member

Can we handle this in Javascript for our existing customers as well?

@officiallygod
Copy link
Member Author

Can we handle this in Javascript for our existing customers as well?

Sure, I'll do that too.

arunshenoy99
arunshenoy99 reviewed Aug 23, 2022
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be deleting the build files?

@arunshenoy99 arunshenoy99 merged commit 0c93416 into trunk Aug 25, 2022
@officiallygod officiallygod deleted the bug/PRESS2-96-Fix-Secondary-type-showing-up branch September 20, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@officiallygod @arunshenoy99