Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS0-1954 - Verify Migration Event Reporting on Fork Step shows once #615

Closed
wants to merge 1 commit into from

Conversation

krsomayagi
Copy link
Contributor

Proposed changes

Added a cypress test case to verify Migration Event Reporting on Fork Step shows only once.
https://jira.newfold.com/browse/PRESS0-1954

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 added the WIP PR is a Work in Progress and not ready for review. label Sep 2, 2024
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krsomayagi, the code looks good. Let's move the check of @fork-migrate-event to the existing migration test in this file. Doing this should resolve the failing test.

@arunshenoy99 arunshenoy99 mentioned this pull request Sep 10, 2024
9 tasks
@arunshenoy99
Copy link
Member

Closing in favour of #617

@arunshenoy99 arunshenoy99 deleted the PRESS0-1954 branch September 11, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP PR is a Work in Progress and not ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants