Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS0-1754: Remove Social Connect Step #597

Merged
merged 4 commits into from
Jul 24, 2024
Merged

PRESS0-1754: Remove Social Connect Step #597

merged 4 commits into from
Jul 24, 2024

Conversation

girish-lokapure
Copy link
Contributor

Proposed changes

When a customer selects the AI Site Gen flow, we skip the social step.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@girish-lokapure girish-lokapure marked this pull request as draft July 17, 2024 08:36
@ajayadav09 ajayadav09 self-requested a review July 19, 2024 12:26
@girish-lokapure girish-lokapure marked this pull request as ready for review July 19, 2024 12:28
@ajayadav09
Copy link
Contributor

Pull the latest changes

@ajayadav09
Copy link
Contributor

Should we also remove the step from here ?
src/OnboardingSPA/chapters/sitegen.js

@girish-lokapure
Copy link
Contributor Author

Should we also remove the step from here ? src/OnboardingSPA/chapters/sitegen.js

just to be safe have removed it from here, but I don't see this being imported or used anywhere... !

@ajayadav09 ajayadav09 added the QA This PR is in QA label Jul 23, 2024
@officiallygod officiallygod added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Jul 24, 2024
@officiallygod officiallygod merged commit 08d977a into trunk Jul 24, 2024
3 of 4 checks passed
@officiallygod officiallygod deleted the PRESS0-1754 branch July 24, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants