Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Site Logo Error State #592

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Add Site Logo Error State #592

merged 2 commits into from
Jul 24, 2024

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Jul 1, 2024 •
edited
Loading

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Further comments

Readded the Error State on the Site Logo Step:
Screenshot 2024-07-03 at 3 36 05 PM

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Jul 1, 2024
@officiallygod officiallygod self-assigned this Jul 1, 2024
@officiallygod
Copy link
Member Author

PRESS0-1623

@officiallygod officiallygod added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Jul 3, 2024
@arunshenoy99 arunshenoy99 added QA This PR is in QA and removed Code Review The PR is in Code Review labels Jul 8, 2024
@officiallygod officiallygod added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Jul 24, 2024
@officiallygod officiallygod merged commit d7102a6 into trunk Jul 24, 2024
5 of 6 checks passed
@officiallygod officiallygod deleted the fix/site-logo-error-state branch July 24, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees

@officiallygod officiallygod

Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@officiallygod @arunshenoy99